fix(composer): expand pasted text from chip label#2300
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Iflaqbhat is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
|
The refactor to Two things in the editor context:
Click/keyboard expand path otherwise looks consistent. |
|
@Pablosinyores Thanks, that makes sense. For The Space key point is fair. Since we prevent default scrolling, the current keydown behavior works in practice, but I agree it is slightly different from native button semantics. I can adjust Space to activate on keyup if maintainers prefer that. I’ll do one more local keyboard pass with multiple pasted chips and can tweak if the Tab flow feels too noisy. |
|
Pulled this on Windows and traced through it — clean a11y/UX fix, looks correct. What I checked
I couldn't exercise the click/focus behavior live (that needs the full app running), so this is a static + typecheck pass — but the logic is sound and matches the recording. LGTM. |
|
@Abhijeet1005 Thanks for the feedback and for checking this on Windows! |
Fixes #1843
Summary
Pasted · n lineslabelVerification
git diff --checkpnpm --filter @openwork/app typecheckpnpm --filter @openwork/app testScreen.Recording.2026-06-17.at.12.04.24.PM.mov