fix(settings): align authorized folders empty state#2293
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Iflaqbhat is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
I checked this locally at aa040c4c.
What I could verify:
git diff --check dev...HEAD-> pass- The patch is limited to
apps/app/src/react-app/domains/settings/panels/authorized-folders-panel.tsx - The new empty-state styling uses the existing
Empty variant="ghost"path and DLS tokens, so the code-level change looks consistent with the settings surface.
One thing I would not call fully verified yet: this PR says Fixes #1101, but the block being restyled only renders when visibleAuthorizedFolders.length === 0. In current code, visibleAuthorizedFolders prepends workspaceRootFolder whenever the server/selected workspace root is known, so the normal “no external folders authorized” state should still render the workspace-root row rather than this Empty block. That matches the earlier issue comment where the broken overlay could not be reproduced on dev without a more specific state.
Could you attach a screenshot or the exact app state where this Empty block renders after the change, for example no runtime workspace root / empty selected workspace root? Without that, the fallback restyle looks reasonable, but I would not treat the #1101 repro as fully validated yet.
|
@sid-valecha Updated in 6eb552e. Thanks, you were right. I updated the implementation so the empty state is now reachable in the normal no-external-folders state. The workspace root row is rendered separately, and external authorized folders are tracked separately. When there are no external folders, the DLS-styled empty state renders below the workspace root row. Verified locally in Settings > Permissions with a workspace root and no external folders: the root row remains visible and the empty state renders naturally without demo flags. Checks:
|
|
The split between the always-on workspace-root row and the external-folders list reads much cleaner, and scoping the empty state to Just confirming the intended UX: when a workspace root is set but there are no external folders, |
|
@Pablosinyores Thanks, yes, that is the intended UX. I verified visually in Settings > Permissions with a workspace root and no external folders. The workspace root row stays visible, and the external-folders empty state renders below it. The dashed empty block reads as a separate external-folder state rather than a half-empty root panel. The copy is external-specific: “No external folders authorized”, so showing both together feels correct. |

Summary
Verification