SVA: replace sva_sequence_concatenation_exprt
#1162
Draft
+180
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
remove-sva-sequence-concatenation
branch
2 times, most recently
from
72d9130 to
2436062
Compare
This adds a PRECONDITION on the starting timeframe to the word-level SVA sequence encoding.
kroening
force-pushed
the
remove-sva-sequence-concatenation
branch
from
2436062 to
a86335d
Compare
This adds parentheses around the arguments of SVA ## to avoid ambiguity.
kroening
force-pushed
the
remove-sva-sequence-concatenation
branch
2 times, most recently
from
4a79fd5 to
8544473
Compare
This replaces the sva_sequence_concatenation_exprt by multi-operand variants of sva_cycle_delay_exprt, sva_cycle_delay_plus_exprt and sva_cycle_delay_star_exprt. This simplifies the implementation of the SystemVerilog concatenation rules.
kroening
force-pushed
the
remove-sva-sequence-concatenation
branch
from
8544473 to
cfe36b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
sva_sequence_concatenation_exprtby multi-operand variants ofsva_cycle_delay_exprt,sva_cycle_delay_plus_exprtandsva_cycle_delay_star_exprt.This simplifies the implementation of the SystemVerilog concatenation rules.