Skip to content

Conversation

@tautschnig
Copy link
Collaborator

  1. Duplicate some code to specialise it for signed/unsigned and, thereby, add clarity.
  2. De-duplicate code to handle all cases directly in lt_or_le.
  3. Make sure we constant-propagate whatever is possible in unsigned comparison to avoid introducing unnecessary fresh literals. Previously, we would create fresh literals even when comparing constant values.
  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

1. Duplicate some code to specialise it for signed/unsigned and,
   thereby, add clarity.
2. De-duplicate code to handle all cases directly in lt_or_le.
3. Make sure we constant-propagate whatever is possible in unsigned
   comparison to avoid introducing unnecessary fresh literals.
   Previously, we would create fresh literals even when comparing
   constant values.
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.48%. Comparing base (46f9d54) to head (e73c451).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/flattening/bv_utils.cpp 98.07% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8718      +/-   ##
===========================================
+ Coverage    80.47%   80.48%   +0.01%     
===========================================
  Files         1697     1697              
  Lines       208427   208449      +22     
  Branches        73       73              
===========================================
+ Hits        167735   167776      +41     
+ Misses       40692    40673      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit 558ef2f into diffblue:develop Oct 13, 2025
40 of 41 checks passed
@tautschnig tautschnig deleted the less-than-flattening branch October 13, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants