Skip to content

Conversation

@tautschnig
Copy link
Collaborator

We were still repeatedly using bv[bv.size() - 1] in place, when using sign_bit(bv) adds clarity and avoids having to understand encoding details. Also, use .back() to avoid unnecessary repeat arithmetic (which the compiler may or may not optimise away).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We were still repeatedly using `bv[bv.size() - 1]` in place, when using
`sign_bit(bv)` adds clarity and avoids having to understand encoding
details. Also, use `.back()` to avoid unnecessary repeat arithmetic
(which the compiler may or may not optimise away).
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.47%. Comparing base (46f9d54) to head (3fd45d8).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/flattening/bv_utils.cpp 68.75% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8716      +/-   ##
===========================================
- Coverage    80.47%   80.47%   -0.01%     
===========================================
  Files         1697     1697              
  Lines       208427   208424       -3     
  Branches        73       73              
===========================================
- Hits        167735   167732       -3     
  Misses       40692    40692              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit 4ed00e1 into diffblue:develop Oct 13, 2025
39 of 41 checks passed
@tautschnig tautschnig deleted the use-sign_bit branch October 13, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants