Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsnext:main support #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add jsnext:main support #24

wants to merge 1 commit into from

Conversation

dandv
Copy link

@dandv dandv commented Jun 8, 2017

See jsforum/jsforum#5 and note that while jsnext:main has been superseded by pkg.module (which might get standardized), popular modules like redux and three.js still declare (only) jsnext:main.

@codecov-io
Copy link

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           1      1           
  Branches        1      1           
=====================================
  Hits            1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370276e...50b2390. Read the comment docs.

@diegohaz
Copy link
Owner

diegohaz commented Jun 8, 2017

Thank you, @dandv. I'll take a time to read that issue.

But looking at it, shouldn't we add src to files then? Otherwise src will not be published to npm.

@dandv
Copy link
Author

dandv commented Jun 8, 2017

I've just updated the OP - pkg.module has superseded jsnext:main, and module might get standardized.

Indeed, src should be added to files. I'll let you have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants