web支持asyncsubpackagerules构建配置，修复asyncsubpackagerules指定组件名与组件用已声明组件冲突问题 #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackwang112
force-pushed
the
feat-web-asyncsubpackagerules
branch
from
2b1673e to
7e8a320
Compare
hiyuki
reviewed
Aug 26, 2025
hiyuki
reviewed
Aug 26, 2025
hiyuki
reviewed
Aug 26, 2025
| if (placeholderEntry && !jsonObj.usingComponents[placeholder]) jsonObj.usingComponents[placeholder] = placeholderEntry | ||
| if (placeholderEntry) { | ||
| if (jsonObj.usingComponents[placeholder]) { | ||
| // TODO 如果存在placeholder与已有usingComponents冲突, 重新生成一个组件名，在当前组件后增加一个数字 |
There was a problem hiding this comment.
如果当前usingComponents中的组件就是规则中配置的组件呢，不就重复注册了？
hiyuki
reviewed
Sep 3, 2025
| } = createJSONHelper({ | ||
| loaderContext, | ||
| componentsMap, | ||
| localComponentsMap, |
There was a problem hiding this comment.
入参希望稳定，看是否能够以注册回调的形式处理不同平台的处理差异
hiyuki
reviewed
Sep 15, 2025
| tarRoot, | ||
| placeholder, | ||
| resourcePath, | ||
| resolveResourcePath, |
There was a problem hiding this comment.
可以直接用resourcePath吧，这个resource是带query的
hiyuki
reviewed
Sep 15, 2025
| return placeholder | ||
| } | ||
|
|
||
| const processAsyncSubpackageRules = (jsonObj, context, { name, tarRoot, placeholder, relativePath, resolveResourcePathMap }, callback) => { |
There was a problem hiding this comment.
rename to processPlaceholder
There was a problem hiding this comment.
jsonObj, context, { name, tarRoot, placeholder, relativePath, resolveResourcePathMap }这些参数都合成到一个对象参数中吧
hiyuki
reviewed
Sep 15, 2025
| }) | ||
| } | ||
|
|
||
| const fillInComponentPlaceholder = (jsonObj, { name: componentName, placeholder, placeholderEntry, resolveResourcePathMap }, callback) => { |
hiyuki
reviewed
Sep 15, 2025
| // 处理 驼峰转连字符 | ||
| input = componentNameCapitalToHyphen('componentPlaceholder')(input) | ||
| // 将 placeholder 中使用的内建组件转化为 mpx-xxx, 并在 usingComponents 填充 | ||
| function fixBuildComponentPlaceholder (input, { mode }) { |
There was a problem hiding this comment.
rename to fixComponentPlaceholder
hiyuki
reviewed
Sep 15, 2025
|
|
||
| const processComponents = (components, context, callback) => { | ||
| if (components) { | ||
| const asyncComponents = [] |
There was a problem hiding this comment.
外层可以包一个waterfall处理串行流程，优雅一些，不然好多callback处理
hiyuki
reviewed
Sep 15, 2025
| pageConfig: ${JSON.stringify(pageConfig)}, | ||
| // @ts-ignore | ||
| componentsMap: ${shallowStringify(componentsMap)}, | ||
| componentsMap: componentsMap, |
hiyuki
reviewed
Oct 9, 2025
| }) | ||
| }, | ||
| ({ asyncComponents, resolveResourcePathMap }, callback) => { | ||
| async.each(asyncComponents, ({ name, tarRoot, placeholder, relativePath }, callback) => { |
There was a problem hiding this comment.
额，如果只有这么点逻辑的话要不还是改回去放回调里吧
hiyuki
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat1: web下支持asyncsubpackagerules配置注入placeholder
feat2: react下placeholder使用内置组件时在usingComponents中注入使用到的内置组件，逻辑与wx保持一致
fix1: 修复asyncsubpackagerules中声明的组件名与当前组件中usingComponents已声明组件名冲突时，asyncsubpackagerules无法生效问题
如下：compA的placeholder会被替换为bbb组件，但预期是aaa
修复后对于冲突的组件名将会在asyncsubpackagerules注入的组件名后加上数字，如下
fix2: 支付宝下asyncsubpackagerules中声明的组件名将会由驼峰转化为破折号