Refactor swiftmailer to symfony mailer #10

AlexzPurewoko · 2024-07-16T04:56:13Z

Problem Statement

Swiftmailer is no longer maintained and they recommend us to use [Symfony Mailer](https://symfony.com/doc/current/mailer.html).

[The end of Swiftmailer (Symfony Blog)](https://symfony.com/blog/the-end-of-swiftmailer)

Plan & Todos

Mencari inspirasi implementasi update pada laravel terbaru, di mana pada versi laravel 9.x, laravel sudah melakukan migrasi dari swiftmailer ke symfony mailer. Adapun versi yang digunakan pada laravel 9.x adalah symfony/mailer 6.0. Versi 9.x laravel dipakai karena lebih dekat implementasinya ke 4.2, menghindari adanya beberapa major change pada versi selanjutnya.
Update dengan menyesuaikan beberapa perubahan yang ada di laravel 9.x beserta testingnya
Setelah update berhasil, menyesuaikan implementasi pada dicoding codebase

AlexzPurewoko · 2024-08-28T07:44:49Z

Kira kira ini mau di evaluate kapan yak?

AlexzPurewoko · 2024-09-05T04:58:01Z

Kira kira ini mau di evaluate kapan yak?

AlexzPurewoko · 2024-11-05T04:46:55Z

Guys sepertinya ini akan obsolete ketika tidak di implementasikan

rizqyhi · 2025-02-19T07:17:58Z

src/Illuminate/Auth/Reminders/PasswordBroker.php

-	 * @return \Illuminate\Auth\Reminders\RemindableInterface
-	 *
-	 * @throws \UnexpectedValueException
-	 */
-	public function getUser(array $credentials)
-	{


@AlexzPurewoko ada pertimbangan tertentu kenapa return value-nya jadi nullable dan throw-nya dihapus?

Ga ada bang karena pas dulu aku cuma lihat retrieveByCredentials() di interface. Dia possible untuk return null disitu.

Disini hanya mempertegas saja si return valuenya, soalnya pengecekan if statement di line selanjutnya hanya berlaku untuk user not null

rizqyhi · 2025-02-19T07:24:09Z

src/Illuminate/Mail/Transport/LogTransportV2.php

@AlexzPurewoko kenapa perlu dibuat V2?

rizqyhi · 2025-02-19T07:24:44Z

src/Illuminate/Mail/composer.json

@@ -13,7 +13,8 @@
        "illuminate/log": "4.2.*",
        "illuminate/support": "4.2.*",
        "illuminate/view": "4.2.*",
-        "swiftmailer/swiftmailer": "~5.1"
+        "swiftmailer/swiftmailer": "~5.1",


@AlexzPurewoko switftmailer-nya ngga sekalian dihapus aja?

Your requirements could not be resolved to an installable set of packages. Problem 1 - Root composer.json requires illuminate/queue 4.2.* -> satisfiable by illuminate/queue[v4.2.0-BETA1, ..., 4.2.x-dev]. - Root composer.json requires symfony/mailer ^6.4 -> satisfiable by symfony/mailer[v6.4.0-BETA1, ..., 6.4.x-dev]. - illuminate/http[v4.2.0-BETA1, ..., 4.2.x-dev] require symfony/http-kernel 2.5.* -> satisfiable by symfony/http-kernel[v2.5.0-BETA1, ..., 2.5.x-dev]. - illuminate/queue[v4.2.0-BETA1, ..., 4.2.x-dev] require illuminate/http 4.2.* -> satisfiable by illuminate/http[v4.2.0-BETA1, ..., 4.2.x-dev]. - symfony/mailer[v6.4.0-BETA1, ..., 6.4.x-dev] conflict with symfony/http-kernel v2.5.8. - symfony/mailer[v6.4.0-BETA1, ..., 6.4.x-dev] conflict with symfony/http-kernel v2.5.3. - symfony/mailer[v6.4.0-BETA1, ..., 6.4.x-dev] conflict with symfony/http-kernel v2.5.0. - symfony/mailer[v6.4.0-BETA1, ..., 6.4.x-dev] conflict with symfony/http-kernel v2.5.0-BETA1. - symfony/mailer[v6.4.0-BETA1, ..., 6.4.x-dev] conflict with symfony/http-kernel 2.5.x-dev.

Aku kena ini mas @rizqyhi pas run composer remove...

@AlexzPurewoko kamu kena ini pas apa? Aku coba reproduce gabisa.

Coba mas execute composer remove symfony mailer

Eh sorry mas, masuk ke directory Illuminate/Mail, then execute composer remove swiftmailer/swiftmailer

Eh tapi gimana kalau ini di PR terpisah aja mas @rizqyhi ? reference dari provider udah di set ke LogTransportV2 sih. jadi pandanganku dah aman

Soalnya kan ada Mailgun dan Mandrill transport nih, buat jaga - jaga aja di prod. Soalnya kalau dependensi swift mailer di remove, nanti perlu remove dua implementasi transport itu jg

rizqyhi · 2025-02-19T07:46:31Z

src/Illuminate/Mail/Mailer.php

 		// If the given view is an array with numeric keys, we will just assume that
 		// both a "pretty" and "plain" view were provided, so we will return this
 		// array as is, since must should contain both views with numeric keys.
 		if (is_array($view) && isset($view[0]))
 		{
-			return $view;
+			return [$view[0], $view[1] ?? null];


@AlexzPurewoko kenapa perlu mengecek masing-masing element? Kalau melihat deskripsi di atas, lebih masuk akal mengembalikan $view langsung.

rizqyhi · 2025-02-19T07:53:14Z

src/Illuminate/Mail/Mailer.php

-		elseif (is_string($callback))
+		else
 		{
 			return $this->container[$callback]->mail($message);
 		}
-
-		throw new \InvalidArgumentException("Callback is not valid.");


@AlexzPurewoko kenapa exception ini dihapus?

rizqyhi · 2025-02-19T07:57:10Z

composer.json

@@ -31,6 +31,7 @@
        "symfony/finder": "~6.4",
        "symfony/http-foundation": "~6.4",
        "symfony/http-kernel": "~6.4",
+        "symfony/mailer": "^6.4",


@AlexzPurewoko swiftmailer di list ini juga perlu dihapus.

rizqyhi · 2025-02-19T08:12:13Z

src/Illuminate/Mail/Message.php

+	public function sender(string $address, ?string $name = null): self
 	{
-		$this->swift->setSender($address, $name);
+		$this->message->sender(new Address($address, $name));


@AlexzPurewoko parameter $name di constructor Address ngga nullable, jadi ini perlu diberi pengaman seperti di method from di atas.

AlexzPurewoko added 3 commits July 16, 2024 10:44

add symfony mailer

df246a1

refactor message structure to accept symfony email

5d59c56

refactor test

1d72fb2

AlexzPurewoko self-assigned this Jul 16, 2024

AlexzPurewoko added 16 commits July 16, 2024 13:43

add refactored log transport

b8a6014

add forwardscalls

308e73f

add sent message

56e257e

refactor mailer

593ac47

add array transport

50100e3

fix addressing

b52fb91

fix some methods

bbf5268

fix test testMailerSendSendsMessageWithProperViewContent

d9771cf

refactor the MailMailerTest

87cfa1e

cleaning up

6e8af0f

add symfony http client and mailgun mailer

25a8139

completely refactor the mail service provider

7144ff5

remove the unused comments

85ba199

refactor failed test

26098e3

refactor password broker

8f60758

remove temporary

9ae3989

AlexzPurewoko marked this pull request as ready for review July 18, 2024 05:17

AlexzPurewoko requested a review from rizqyhi July 26, 2024 01:31

rizqyhi reviewed Feb 19, 2025

View reviewed changes

AlexzPurewoko added 4 commits June 10, 2025 16:06

add test from laravel 9.x

6915abe

pass test

856a6f5

remove swiftmailer

49ec16d

add optional for safe null

06edba0

update the symfony packages

51d0763

Refactor swiftmailer to symfony mailer #10

Are you sure you want to change the base?

Refactor swiftmailer to symfony mailer #10

Conversation

AlexzPurewoko commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Plan & Todos

Uh oh!

AlexzPurewoko commented Aug 28, 2024

Uh oh!

AlexzPurewoko commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexzPurewoko commented Nov 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexzPurewoko commented Jul 16, 2024 •

edited

Loading

AlexzPurewoko commented Sep 5, 2024 •

edited

Loading