Add validations to exchange action in sessions controller #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykim13
commented
Jul 3, 2024
| # it 'creates an OAuth session and serializes the token data' do | ||
| # call_endpoint | ||
| # expect(response).to have_http_status(:ok) | ||
| ### need to create expected endpoint tests |
There was a problem hiding this comment.
@dickdavis I may add another test here to test endpoint response or include that down the road in another PR that tests the type of resource or type of subject_token_type
Sorry for the little commits, I was trying to figure out what my github wasn't properly linking the commits. It should be properly linked now to the right email. It was set to some strange email before 😅 @dickdavis
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Adds validations to the
#exchangeaction in sessions_controller.rb. It is validating the presence ofresource:andsubject_token_type:.Follow these steps to test this PR:
Run
bundle exec rspec spec/requests/oauth/sessions_controller_spec.rb