Check missile source type to determine death reason #7486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where Runes could be used to PK another player and have them drop their equipment as if they had been killed by a trap or monster.
TARGET_BOTH
is only used for a handful of missiles:For Fire Wall, Lightning Wall, and Ring of Fire, we were already checking
missile.IsTrap()
which is equivalent tomissile.sourceType() == MissileSource::Trap
. Therefore, the behavior after the change should match what we were doing before. Phasing is harmless, so the only real change is that Rune missiles will now also useDeathReason::Player
.This logic also just makes more sense compared to the special case for Fire Wall and Lightning Wall.