Replace OOB guards with safe RNG calls when initialising quests

[ephphatha]

In order to hit the case that the QuestGroup2 and QuestGroup3 checks were guarding against a player would need to edit their save or modify the game to allow storing a raw seed value instead of the output of AdvanceRndSeed(). Since this can't happen in normal gameplay I don't think it's necessary to keep compatibility here. The other mitigating factor is quest availability is saved as part of the game state so there's no issues loading these saves on vanilla diablo or in devX.

It's possible that someone playing on an NT-based windows could set their system time to the 1977 date and start a new game at a time that lands on the seed 988045466 for dlvl 15. To ensure we leave all quests in this group active (as vanilla does) I've checked for that seed explicitly.

Massive props to staphen for doing the legwork to point out what quests impact level generation (and the overall discussion in discord), that gave me the idea to see if these checks actually impact normal gameplay.

[AJenbo]

Any tests you would like me to try and run on a PowerPC Mac?

[ephphatha]

Any tests you would like me to try and run on a PowerPC Mac?

Could you please try creating a save game with the system date set to 2039 or later? If it has the same behaviour as windows I expect the level table to look like the following no matter what date/time you start a new game at:

 0:   22695476 -- Town seed might end up rerolled
 1: 2110654659
 2: 1444857250 (with Poisoned Water Supply [Q_PWATER])
 3: 1368016523
 4: 1526527176 (with Ogden's Sign [Q_LTBANNER])
 5: 1086087831 (with Valor [Q_BLOOD])
 6:  220228418 (with Chamber of Bone [Q_SCHAMB])
 7: 1885843287 (with Halls of the Blind [Q_BLIND])
 8:  663105788
 9: 1179446315
10:  805306086 (with Anvil of Fury [Q_ANVIL])
11: 1921374621
12: 1674189952
13: 1031346559 (with Warlord of Blood [Q_ANVIL])
14:  360511818
15: 1960323153
16: 1971124540

[AJenbo]

Several crashes and freezes later:
diablo spawn 0.zip
(I don't even know if this is the same save format as the PC version... but it should be, just and odd file name)
The save was done using the 1.08 spawn version.

[ephphatha]

Doesn't look like it accepted the system time change:

DungeonSeeds[]:
  | [1] | 905263464 | unsigned int
  | [2] | 2043843209 | unsigned int
  | [3] | 1852314718 | unsigned int
  | [4] | 416078711 | unsigned int
...

Starting seed: 1710044994 (2024-03-10 04:29:54 AM can be reached by setting the windows clock)
 0:  270961835
 1:  905263464
 2: 2043843209
 3: 1852314718 (with The Curse of King Leoric [Q_SKELKING])
 4:  416078711 (with Ogden's Sign [Q_LTBANNER])
...

[AJenbo]

Nice investigation and comments :)