Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: DLVL 16 speech after Diablo death #7008

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented Mar 7, 2024

Fixes: #6879

Prevents the speech from playing upon entering dungeon level 16 if Diablo is already dead.

@kphoenix137 kphoenix137 changed the title Bugfix: DLVL 16 message after Diablo death Bugfix: DLVL 16 speech after Diablo death Mar 7, 2024
@kphoenix137 kphoenix137 added the fix fix for a bug label Mar 7, 2024
Source/player.cpp Outdated Show resolved Hide resolved
sfxdelay = 40;
sfxdnum = SfxID::DiabloGreeting;
myPlayer.pDungMsgs |= DungMsgDiablo;
for (auto &monster : Monsters) {
Copy link
Member

@AJenbo AJenbo Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we prefer not having auto here since the type isn't immediately obvious. But heck I don't remember what the monster struct name is atm.

@AJenbo AJenbo merged commit ad452cb into diasurgical:master Mar 15, 2024
21 of 22 checks passed
@kphoenix137 kphoenix137 deleted the fix-dlvl16-message branch March 16, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue Report]: Diablo's speech played on dlvl 16 when joining the game after he's been killed.
2 participants