Bugfix: Auto Refill Belt not working properly #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6909
The Auto Refill Belt game option was not correctly setting the
spellFromvariable (orciias in the scope usage). The scroll/rune from the inventory or end of the belt was correctly targeted, but the spell itself would cast from the slot that was initially used, causing it to consume whatever item was originally targeted. The logic for Auto Refill Belt already implied that the intended use case was to match items based on spell, so it was already intended that scrolls and runes would refill, therefore I labeled this as a bugfix rather than a feature addition.