Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique items InfoBox in stash in 800x600 and lower resolutions #6983

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

PaintingTs
Copy link
Contributor

@PaintingTs PaintingTs commented Feb 23, 2024

Motivation: With 800x600 and lower resolutions it is not possible to see unique item's info-box in your stash or when both left- and right-side panels are open.

Solution: Showing overlapping info-box with a darker background in the cases above.

Before:
Screenshot from 2024-02-23 22-47-15

After:
Screenshot from 2024-02-23 22-48-07

Bonus: changed alignment of info-box for unique items in the stash.
Before:
Screenshot from 2024-02-23 22-46-05

After:
Screenshot from 2024-02-23 22-44-26

…ashed unique items show InfoBox near the Stash Panel
@FitzRoyX
Copy link

FitzRoyX commented Mar 2, 2024

Displaying the old box ontop of the a panel isn't an elegant solution because of how unnecessarily large and padded it is. This does the same thing with 1/3 the obstruction.

@AJenbo AJenbo merged commit 00c8882 into diasurgical:master Mar 2, 2024
22 checks passed
@AJenbo
Copy link
Member

AJenbo commented Mar 2, 2024

Sorry I thought I had already merged this. The floating box is probably more for the modern UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants