Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polish translation #6963

Closed
wants to merge 4 commits into from
Closed

Update Polish translation #6963

wants to merge 4 commits into from

Conversation

Wickez
Copy link

@Wickez Wickez commented Feb 14, 2024

Unified the wording for certain spots (especially for "defense", "armor", "armor class", "damage", "durability" discrepancies), introduced some clarification to particular monster's messages (resistances and immunities), added missing . and : in some places, leveled and streamlined the confusing strings for certain weapon suffixes, and tackled them oils' descriptions.

The rest is swell, as expected of such a massive project that attracted Diablo lovers from all over the world, including Poland.

Unified the wording for certain spots (especially for "defense", "armor", "armor class", "damage", "durability" discrepancies), introduced some clarification to particular monster's messages (resistances and immunities), added missing . and : in some places, leveled and streamlined the confusing strings for certain weapon suffixes, and tackled them oils' descriptions.

The rest is swell, as expected of such a massive project that attracted Diablo lovers from all over the world, including Poland.
@AJenbo
Copy link
Member

AJenbo commented Feb 14, 2024

What do you think of this one @qndel?

@qndel
Copy link
Member

qndel commented Feb 14, 2024

Not a fan of all the random changes, like adding "." to shrine messages when originally there is none, changing capital letters for no reason (again, not matching original text) etc. ideally split it into smaller commits with 1 theme each so it's easier to review and point out what to change

@Wickez
Copy link
Author

Wickez commented Feb 15, 2024

Don't bother. My input was optional and I don't want to waste anyone time with "random changes". I will simply drop this and compile myself with changes I desire from the source for my personal use.

Cheers.

@Wickez Wickez closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants