Fix MSVC warnings in controls\* #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces warnings by 15 (from 32 to 17)
Changes are
roundcast to intswitch statement contains 'default' but no 'case' labels)The C4065 warning was a bit annoying, as I think the old syntax is fine.
This PR will wrap each switch with another `#ifdef' to see if there is a case present.
An alternative fix would be to ignore the warning. So if we think this is better, we can change the PR.
Note: I haven't been able to test this PR because I don't own a joystick, let alone a device which enables the defines.