Use uint8_t in msg/multi/sync and fix MSVC warnings #6856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces warnings by 33 (from 74 to 41).
One of the big changes is the use of
uint8_tinstead ofsize_tfor player id in msg/multi/sync/network code (see also discussion in #6849).I noticed that
SNPLAYER_ALLwas not being used (now removed).Another thing is that
size_tis now mostly used to pass memory sizes around in msg/multi/sync.The rest are just minor MSVC warning fixes.
Sorry this PR is a bit bigger, but I tried to make different commits to make the review process easier.