Introduce GetDunSize and remove global SetPiece Handling #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three refactorings
GetDunSizeto get the ".dun"-size. Use this in every place aWorldTileSizeis needed. (first commit)GetDunSizealso in loops. I'm not 100% of this, that's also why this is a separate commit. (second commit)pSetPieceand it's related helper functions (SetSetPieceRoomandFreeQuestSetPieces) with a anonymous function in each level generator (InitSetPiece). Less global variables. 😁 (third commit)This PR also reduces warnings by 16 (from 153 to 137).