Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Monster::occupyTile #6839

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Introduce Monster::occupyTile #6839

merged 2 commits into from
Nov 26, 2023

Conversation

obligaron
Copy link
Contributor

Monsters are only updated dMonster with a non-zero value in Monster::occupyTile.

This PR reduces warnings by 23 (from 191 to 168).

AJenbo
AJenbo approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this abstraction a lot 👍

@AJenbo AJenbo merged commit f3831de into diasurgical:master Nov 26, 2023
23 checks passed
@obligaron obligaron deleted the monstertile branch November 26, 2023 16:40
@obligaron
Copy link
Contributor Author

Next will be Player::occupyTile 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJenbo AJenbo AJenbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obligaron @AJenbo