Handle PT_DISCONNECT packets more gracefully #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
previously approved these changes
Nov 22, 2023
StephenCWills
force-pushed
the
no-tcp-abort
branch
from
91b2515
to
b90dd29
Compare
AJenbo
approved these changes
Nov 22, 2023
glebm
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the abort suggests that the owner should not be sending
PT_DISCONNECTpackets to the player being dropped, the first commit avoids that possibility in the TCP server by disconnecting the client socket before sending the packet.The second commit treats the error as non-fatal to avoid the possibility of a malicious client triggering a crash in remote clients.