Redo Vision

[kphoenix137]

Creates a more consistent and realistic area of vision. Makes the vision radius as close to a circle as we can get, which also fixes the bug with the player turning invisible with lowest achievable light radius.

Before:

After:

Before:

After:

Before:

After:

[julealgon]

Just one comment based on the comparisons.

I prefer the behavior here (original):

Than the new one:

The former looks a lot more natural to me.

[kphoenix137]

Just one comment based on the comparisons.

I prefer the behavior here (original):

Than the new one:

The former looks a lot more natural to me.

Because it doesn't discriminate based on the actual shape of the dungeon tile. It behaves as if the entire tile is filled with solid, which in that case you would not be able to see many of the tiles the vanilla one covers. Should I add special handling for every type of solid tile based on how wide the graphic is? Or maybe change how it "looks" in a direction by ignoring a solid tile if it's in the outer ~50% space of the solid tile

[julealgon]

Should I add special handling for every type of solid tile based on how wide the graphic is? Or maybe change how it "looks" in a direction by ignoring a solid tile if it's in the outer ~50% space of the solid tile

To be fair I'm not sure either. I just think it needs to be a cone (or since we are dealing 2d, triangle) shape from the character to model the idea that you see more further ahead than you do nearby.

A simple "line" won't work well I think because of this.

[qndel]

not that I care but this would make pulling single monsters trivial in ironman by just poking them with the protruding 1 tile part

[kphoenix137]

Should I add special handling for every type of solid tile based on how wide the graphic is? Or maybe change how it "looks" in a direction by ignoring a solid tile if it's in the outer ~50% space of the solid tile

To be fair I'm not sure either. I just think it needs to be a cone (or since we are dealing 2d, triangle) shape from the character to model the idea that you see more further ahead than you do nearby.

A simple "line" won't work well I think because of this.

Desktop.2023.08.02.-.17.21.12.08.mp4

I modified the function and now it casts 360 rays, utmost realism and precision

[julealgon]

A bit hard to judge compared to the original (or even to what one would consider "perfect", which I actually don't know), but that's looking good to me at least.

Is there a significant performance implication with the change?

[kphoenix137]

A bit hard to judge compared to the original (or even to what one would consider "perfect", which I actually don't know), but that's looking good to me at least.

Is there a significant performance implication with the change?

Not sure. someone with a low end system will have to test

[kphoenix137]

not that I care but this would make pulling single monsters trivial in ironman by just poking them with the protruding 1 tile part

Check OP again

[kphoenix137]

A bit hard to judge compared to the original (or even to what one would consider "perfect", which I actually don't know), but that's looking good to me at least.

Is there a significant performance implication with the change?

I was able to reduce the amount of rays to 64 from 360 and still maintain a good level of accuracy

[Gerwin2k]

float dx = std::cos(angle * M_PI / 180.0f);
float dy = std::sin(angle * M_PI / 180.0f);

For your consideration. In the past, like 20 years ago, it was common to pre-calculate all possible answers at game startup and store these results in an array. Then when the game was running; lookup the answers from the array to avoid doing sin and cos when timing is critical.
example.txt

[AJenbo]

Title is misleading :(

"Refactoring" in programming refers to the process of restructuring existing computer code without changing its external behavior. It's like tidying up your code to make it more readable, maintainable, and efficient without altering what it actually does.

[kphoenix137]

Gotta redo time demo probably 😅

I incorrectly named the tables so I'll need to revise those.