Remove unused attribute _pMaxLvl #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split this one from #6404 as it requires changing the reference save for the timedemo test.
In diablo/hellfire when a player is packed the maxLevel attribute is not saved. When the player is unpacked the Player struct is not memset and the maxLevel attribute is not initialised. This leaves whatever value happened to be there from a previous session (might be the current character, might be a different character). Either way it's never used so there's no harm setting it to 0 in the save file.
I did not re-record the demo, I just replaced the reference save with the actual save created from a test run after this change.