Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spectral Arrow hack code #6374

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented Jul 16, 2023

Based on: #6336

Refactors logic regarding "Spectral Arrow"

In AddSpectralArrow(), this function is set up as if it was a function for an actual arrow; setting up missile velocity. The velocity is altered by player class and items that increase attack speed. The velocity is passed in var3 which was used in ProcessSpectralArrow as spllvl, which affects the velocity of Fireballs shot from Flambeau, (and perhaps Blitzen and Thunderclap, but was not tested). The velocity is increased by using a Rogue, Warrior, or Bard, as well has having items that increase Attack Speed (which is impossible when wielding a bow), which is the reason I believe this was done in error.

The missileID is no longer extrapolated from player lightning damage (considering this has proven to cause bugs), but instead now iterates equipment items and check if the iterated item is Unique, and checks the item powers it has to find out if it has one of the applicable effects, and writes it to the missile struct as var4.

I considering adding Hellfire Item Effect flags for these items, however I think that would cause reverse compatibility problems.

@AJenbo AJenbo added this to the 1.6.0 milestone Jul 16, 2023
@AJenbo AJenbo reopened this Sep 18, 2024
@AJenbo AJenbo marked this pull request as draft September 18, 2024 14:57
@AJenbo
Copy link
Member

AJenbo commented Sep 18, 2024

Needs a rebase

@kphoenix137 kphoenix137 marked this pull request as ready for review September 19, 2024 00:30
@kphoenix137 kphoenix137 changed the title Fix Donald's stupid hack Fix Spectal Arrow hack code Sep 19, 2024
@kphoenix137 kphoenix137 changed the title Fix Spectal Arrow hack code Fix Spectral Arrow hack code Sep 19, 2024
@kphoenix137 kphoenix137 marked this pull request as draft September 19, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants