Consume Resource After Successful Spell/Oil Usage #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need help with the time demo |
|
It's broken because your PR is broken. Go cast a Heal scroll and then try to do something after. |
Nothing else changed besides Scroll of Identify. Also casting scroll of identify directly from speed spell does not work, as only right clicking a Scroll gives the targeting cursor, not actually casting the spell.
|
Any brave souls willing to playtest this? Also I cannot figure out how to correctly handle oils. Any help would be appreciated. The problematic line has |
kphoenix137
changed the title
qndel
reviewed
Jul 9, 2023
| ConsumeSpell(player, spl); | ||
| } |
There was a problem hiding this comment.
imo avoid adding empty diff like in this file - changes not really relevant to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will redefine the behavior of spells that use a targeting cursor.
Default behavior:
Fixed Scroll behavior
Oils will behave in the same manner, not being consumed until successfully used.
Fixes #6105
Fixes #6324