-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ItemSpecialEffect::Indestructible #5772
base: development
Are you sure you want to change the base?
Add ItemSpecialEffect::Indestructible #5772
Conversation
497b7bc
to
0f0e84b
Compare
Won't this break Hellfire items that have been oiled to be indestructable? |
It absolutely will. I forgot about Hellfire Oils entirely. Oil of Permanence in specific is problematic. |
The only thing I can think to do about that is to add a flag to Well, either that, or we can simply ignore the problem. Continue to allow SP Hellfire players to abuse Hidden shrines since they have access to Oil of Permanence anyway. |
Adds a new flag for Indestructible, so that 255 durability doesn't need to be used as indestructible. Indestructible items are given both the new flag, and also have their durability set to 255 for reverse compatibility. Also added code in
CalcPlrItemVals()
to force set the flag on any existing item if it hasIPL_INDESTRUCTIBLE
but doesn't already have the flag (for reverse compatibility).