Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a function bug in subsystem_variables.gd #2025

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

endaye
Copy link
Contributor

@endaye endaye commented Jan 18, 2024

image

image

When setting a dialogic variable in code, it shows a bug here after alpha 12.

The method called _set_value_in_dictionary in outside as VariableFolder has been removed since commit Variables Rework (second PR attempt) (#1972)

I think this is a missing part.

@Jowan-Spooner
Copy link
Collaborator

Thank you very much! This was indeed a mistake I made.

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Critical 💩 labels Jan 18, 2024
@Jowan-Spooner Jowan-Spooner merged commit 0fd1d46 into dialogic-godot:main Jan 18, 2024
2 checks passed
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
When setting a dialogic variable in code, it showed a bug here after alpha 12.

The method called _set_value_in_dictionary in outside as VariableFolder has been removed since commit Variables Rework (second PR attempt) (dialogic-godot#1972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Critical 💩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants