Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User Input Auto-Advance #2024

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

CakeVR
Copy link
Collaborator

@CakeVR CakeVR commented Jan 16, 2024

Fixes Auto-Advance enabled until the next user input not ending on user input.

Fixes the PR #2022.

This PR fixes unit tests relying on the Dialogic autoload.

@CakeVR CakeVR added the Bug 🐞 Something isn't working label Jan 16, 2024
@Jowan-Spooner
Copy link
Collaborator

Lgtm

@Jowan-Spooner Jowan-Spooner merged commit d8df1d7 into dialogic-godot:main Jan 16, 2024
2 checks passed
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
* Fix incorrect Auto-Advance flag being disabled.

* Add missing double newline between methods.

* Add tests for Auto-Advance.

* Add `[autoload]` to the project file.

* Remove `class_name` from unit tests.
@CakeVR CakeVR deleted the fix-user-input-auto-advance branch February 28, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants