Add check preventing restarting the same audio resource. #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems a bit unnecessary to do the check in the event, couldn't we simply check it in the subsystem? |
Personally, I think game logic should happen in events and the subsystem for audio executes the request. |
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
…dot#2002) * Add check preventing restarting the same audio resource. * Fix docs. * Move resource check to the Audio subsystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2001 and fixes the background music event when its restarting the identical playing audio resource.