Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply type hints to example scripts to avoid triggering any GDScript warnings or errors #1975

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Apply type hints to example scripts to avoid triggering any GDScript warnings or errors #1975

merged 13 commits into from
Jan 12, 2024

Commits on Jan 4, 2024

  1. Add static type hints to visual novel example

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4ef6647 View commit details
    Browse the repository at this point in the history

  2. Added types to the textbubble and speaker_textbubble examples

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b21d819 View commit details
    Browse the repository at this point in the history

  3. Reverted some changes that were unnecessary.

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    703cb38 View commit details
    Browse the repository at this point in the history

  4. Replaced @onready node variables with getters

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    678aab3 View commit details
    Browse the repository at this point in the history

  5. Add static type hints to visual novel example

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6a0a242 View commit details
    Browse the repository at this point in the history

  6. Added types to the textbubble and speaker_textbubble examples

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    212d108 View commit details
    Browse the repository at this point in the history

  7. Reverted some changes that were unnecessary.

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4ab1dc7 View commit details
    Browse the repository at this point in the history

  8. Replaced @onready node variables with getters

    @nlupugla
    nlupugla committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    09b5d8d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Removed changes to subsystems

    @nlupugla
    nlupugla committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d293c91 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Adjust static typing spaces 

    As Cake pointed out
var inferred := 123
var explicit: int = 123

So I tried to enforce that on the layers.
    @Jowan-Spooner
    Jowan-Spooner committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    73995f9 View commit details
    Browse the repository at this point in the history

  2. Reverted changes to dialogic nodes and applied some misc static type … 

    …fixes
    @nlupugla
    nlupugla committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9727cbb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into add-static-type-hints

    @Jowan-Spooner
    Jowan-Spooner committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ebb0e71 View commit details
    Browse the repository at this point in the history

  4. Reverted some changes involving DialogicSubsystem. WARNING: this comm… 

    …it will raise GDScript errors until the subsystems get types.
    @nlupugla
    nlupugla committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f54738b View commit details
    Browse the repository at this point in the history