Skip to content

Commit

Permalink
Fix history event
Browse files Browse the repository at this point in the history
- fixes #2033
  • Loading branch information
Jowan-Spooner committed Jan 24, 2024
1 parent 70a7ebf commit 555612a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
8 changes: 4 additions & 4 deletions addons/dialogic/Modules/History/event_history.gd
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ var action := Actions.PAUSE
func _execute() -> void:
match action:
Actions.CLEAR:
dialogic.History.full_history = []
dialogic.History.simple_history_content = []
Actions.PAUSE:
dialogic.History.full_history_enabled = false
dialogic.History.simple_history_enabled = false
Actions.RESUME:
dialogic.History.full_history_enabled = true
dialogic.History.simple_history_enabled = true

finish()

Expand All @@ -50,7 +50,7 @@ func get_shortcode_parameters() -> Dictionary:
return {
#param_name : property_info
"action" : {"property": "action", "default": Actions.PAUSE,
"suggestions": func(): return {"Clear":{'value':0}, "Pause":{'value':1}, "Resume":{'value':2}}},
"suggestions": func(): return {"Clear":{'value':0, 'text_alt':['clear']}, "Pause":{'value':1, 'text_alt':['pause']}, "Resume":{'value':2, 'text_alt':['resume', 'start']}}},
}

################################################################################
Expand Down
7 changes: 3 additions & 4 deletions addons/dialogic/Modules/History/subsystem_history.gd
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ extends DialogicSubsystem

## Subsystem that manages history storing.

signal already_read_event_reached
signal not_read_event_reached

signal open_requested
signal close_requested

Expand All @@ -25,6 +22,8 @@ signal full_event_history_changed
var already_read_history_enabled := false
var already_read_history_content := {}
var _was_last_event_already_read := false
signal already_read_event_reached
signal not_read_event_reached


#region INITIALIZE
Expand Down Expand Up @@ -69,7 +68,7 @@ func get_simple_history() -> Array:
#region FULL EVENT HISTORY
####################################################################################################

# called on each event
## Called on each event
func store_full_event(event:DialogicEvent) -> void:
if !full_event_history_enabled: return
full_event_history_content.append(event)
Expand Down

0 comments on commit 555612a

Please sign in to comment.