Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent dataElement used for styling from disappearing from popup #3481

Open
wants to merge 3 commits into
base: feat/release-DHIS2-17711-and-DHIS2-19008-and-DHIS2-19047
Choose a base branch
from

Conversation

BRaimbault
Copy link
Collaborator

@BRaimbault BRaimbault commented Mar 3, 2025

Implements DHIS2-17711


Description

name of styleDataItem is not saved with map, get the name with loadDisplayElements just as other data elements marked to be displayed.

Note: To reproduce, do not select a data element for styling that is marked to be displayed in report.

TODO

  • Dashboard tested
  • Tests added (Cypress and/or Jest) N/A
  • Docs added N/A
  • Strings generated N/A
  • d2-ci dependency replaced N/A

Screenshots

image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 3, 2025

🚀 Deployed on https://pr-3481.maps.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify March 3, 2025 08:55 Inactive
@BRaimbault BRaimbault changed the base branch from master to feat/release-DHIS2-17711-and-DHIS2-19008-and-DHIS2-19047 March 3, 2025 10:12
@dhis2-bot dhis2-bot temporarily deployed to netlify March 3, 2025 10:30 Inactive
@BRaimbault BRaimbault marked this pull request as ready for review March 3, 2025 11:43
BRaimbault added a commit that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants