Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup requests to adhere to new tracker API #2176

Merged
merged 8 commits into from
Feb 10, 2025

Conversation

flaminic
Copy link
Contributor

@flaminic flaminic commented Feb 4, 2025

List of changes:

  • the ouMode parameter is used in our code in for event export, tracked entity export. this does not do anything with the new endpoints and should be replaced by orgUnitMode
  • for events exports, the attachment={metadata}.json parameter does not do anything and should be removed
  • it is not correct in new tracker to use fomat=json and we should instead append .json / .csv at the end
  • links=false is invalid and should be removed
  • On Events import / Tracked entities import / Tracked entities export, under Advanced Options > Event ID Scheme selectors should be removed. Requests should be updated to remove references to these parameters
  • On Events import / Tracked entities import / Events export / Tracked entities export, under Advanced Options > ID Scheme selectors should include the option "Name". Requests should correspondingly be updated to use Name as appropriate
  • We have links to documentation for error codes, but the documentation is wrong, can quickly become out of date. Remove the link.

@flaminic flaminic marked this pull request as draft February 4, 2025 13:47
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 4, 2025

🚀 Deployed on https://pr-2176--dhis2-import-export.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 4, 2025 13:49 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 4, 2025 14:36 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 4, 2025 14:44 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 4, 2025 14:48 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 5, 2025 08:17 Inactive
@flaminic flaminic force-pushed the DHIS2-18929/new-tarcker-api-cleanup branch from fd4907c to 55e342b Compare February 5, 2025 08:34
@dhis2-bot dhis2-bot temporarily deployed to netlify February 5, 2025 08:36 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 5, 2025 10:10 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 5, 2025 13:40 Inactive
@flaminic flaminic changed the title fix: rename ouMode to orgUnitMode cleanup requests to adhere to new tracker API Feb 5, 2025
@flaminic flaminic changed the title cleanup requests to adhere to new tracker API fix: cleanup requests to adhere to new tracker API Feb 5, 2025
@flaminic flaminic marked this pull request as ready for review February 5, 2025 13:45
@flaminic flaminic requested a review from tomzemp February 5, 2025 14:23
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

I noticed a remaining reference to ouMode in one of the test URLs. Not sure if that's intentional?

'https://debug.dhis2.org/dev/api/tracker/trackedEntities.json?ouMode=CAPTURE&format=json&includeDeleted=false&dataElementIdScheme=UID&eventIdScheme=UID&orgUnitIdScheme=UID&idScheme=UID&paging=false&totalPages=false&program=lxAQ7Zs9VYR'

@flaminic flaminic force-pushed the DHIS2-18929/new-tarcker-api-cleanup branch from b78301f to c07ea31 Compare February 10, 2025 10:10
@dhis2-bot dhis2-bot temporarily deployed to netlify February 10, 2025 10:12 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 10, 2025 10:20 Inactive
@flaminic flaminic merged commit ddb0655 into master Feb 10, 2025
8 checks passed
@flaminic flaminic deleted the DHIS2-18929/new-tarcker-api-cleanup branch February 10, 2025 10:23
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.1.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants