chore: metadata query cleanup [DHIS2-18041] #20075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jbee
commented
Feb 26, 2025
| * @param filter the filter that is applied | ||
| * @param value a function to extract the filter property value from an object | ||
| */ | ||
| private record Matcher(Filter filter, Function<IdentifiableObject, Object> value) {} |
There was a problem hiding this comment.
FYI: ATM the Matcher indirection adds no benefit. I started this and then found that the refactoring the getValue needs will be quite extensive so I rather do it in another PR. But this is a preparation for it.
david-mackessy
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemawithClass<T>inQuery(Schemais a service "internal" solution)Queryand propagate it in all APIs and usagesQuery.fromtoQuery.of(since it no longer is created from aSchemabut for/of a object typeClass)Query.setDefaultOrders()addition of actualOrders into the service (since they needSchemainformation)Query.shortNamePersistedto remember if the schema has a persisted short name