fix: use url-safe key and valid base path when rendering apps as web modules

[amcgee]

Prior to this change, custom apps were rendered as WebModules in the /api/apps/menu API (introduced with the removal or struts) with unsanitized name fields. This causes issues when app names have special characters or spaces. Additionally, the "namespace" property renders the relative base path for bundled apps but incorrectly was set to the name for installed apps.

I added also a basePath property to the App class which exposes the relative base path also under the /api/apps endpoint.

Before this change (including also a bundled app for reference):

{
  "name": "dhis-web-event-reports",
  "namespace": "/dhis-web-event-reports",
  "defaultAction": "../dhis-web-event-reports/index.html",
  "displayName": "Event Reports",
  "icon": "../icons/dhis-web-event-reports.png"
},
{
  "name": "android-settings-app",
  "namespace": "android-settings-app",
  "defaultAction": "http://localhost:8080/api/apps/android-settings-app/index.html",
  "displayName": "Android Settings",
  "icon": "http://localhost:8080/api/apps/android-settings-app/dhis2-app-icon.png",
  "description": "Configure synchronization parameters for the DHIS2 Android App, customize appear"
},
{
  "name": "Custom Js Css",
  "namespace": "Custom Js Css",
  "defaultAction": "http://localhost:8080/api/apps/Custom-Js-Css/index.html",
  "displayName": "Custom Js Css",
  "icon": "http://localhost:8080/api/apps/Custom-Js-Css/img/Logo_48.png",
  "description": "Custom Js Css"
}

After this change:

{
  "name": "dhis-web-event-reports",
  "namespace": "/dhis-web-event-reports",
  "defaultAction": "../dhis-web-event-reports/index.html",
  "displayName": "Event Reports",
  "icon": "../icons/dhis-web-event-reports.png"
},
{
  "name": "android-settings-app",
  "namespace": "/api/apps/android-settings-app",
  "defaultAction": "http://localhost:8080/api/apps/android-settings-app/index.html",
  "displayName": "Android Settings",
  "icon": "http://localhost:8080/api/apps/android-settings-app/dhis2-app-icon.png",
  "description": "Configure synchronization parameters for the DHIS2 Android App, customize appear"
},
{
  "name": "Custom-Js-Css",
  "namespace": "/api/apps/Custom-Js-Css",
  "defaultAction": "http://localhost:8080/api/apps/Custom-Js-Css/index.html",
  "displayName": "Custom Js Css",
  "icon": "http://localhost:8080/api/apps/Custom-Js-Css/img/Logo_48.png",
  "description": "Custom Js Css"
}

Note that the relative paths for bundled apps and the lack of case standardization are a bit odd and should probably be improved, but I left those as they were previously for now.

[github-actions]

Instance deployed to https://dev.im.dhis2.org/pr-20074

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud