fix: Redirect should have correct location header [DHIS2-18185] (2.41)

[david-mackessy]

Issue

When a redirect is returned, the URL is having a / stripped out when it shouldn't.
E.g. http://localhost:8080/api/apps/line-listing/ is being returned as http:/localhost:8080/api/apps/line-listing/

Cause

When the forward slash cleaning is done, it is removing an extra slash from http:// to http:/
Because there are no guarantees about the strings and formatting being used currently, it is required to manually add / in several places to make sure to hopefully end up with a correct URL.

Fix

Extract the base url first & remove any trailing slash from it, so we know that whatever string is added afterwards, it should be ok to clean.

Created a util method as this kind of pattern is used in multiple places (these places have also been updated as a matter of safety). This should help keep uniformity and reduce issues.

Testing

Automated

E2E test added
Unit tests added for new util method to help ensure correct URL format is sent.

Manual

Manually tested locally

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud