chore: feat: add prev/nextPage to /potentialDuplicates DHIS2-19021

[teleivo]

• add prev/nextPage to /potentialDuplicates
• align service with our exporter services
  • remove getById
  • name get without byUid
  • throw NotFoundException in get
  • separate List and Page methods

Tests

Extract a TestSetup class from TrackerTest. TrackerTest is not composable. The exporter can be tested using test lifecycle class as most tests can share the same setup and are read only. Code like the deduplication service does read and write. This means we need full control of the test annotations. This is inline with the work we've done on removing the number of test base classes so annotations can live in the test classes themselves.

Duplicate TestSetup and Assertions classes so we can use them in our dhis-test-integration and dhis-test-web-api tests. There is no better way right now to share such code. We could only put it into main but we do not want to include test code in production code. The other option of adding it into dhis-support-test introduces cycles. We should revisit our test module arrangement at some point.

We can share JSON though via dhis-support-test (see tracker/simple_metadata.json and tracker/deduplication/potential_duplicates.json).

• migrate deduplication controller test to postgres like we did for other tests
• move test into correct package
• use the tracker objects like we now do in exporter controller tests
  • add methods to TrackerObjects to find entities. We are already have them in TrackerBundle. We might be able to remove them when we move to using the importer using the actual importer JSON payload.
• add potential duplicate specific TEs in tracker/deduplication/potential_duplicates.json. Note that the UIDs of the duplicate TEs match their tracker/event_and_enrollment.json counterpart expect for the D prefix.
• align service test with our other tests in terms of naming and grouping of arrange, act and assert

Next

• simplify view/Page and integrate types well PageRequestParams -> tracker/PageParams -> tracker/Page -> view/Page
• handle requests to endpoints that do not support totalPages?
• reuse TestSetup to setup metadata and data in tracker integration tests
• reuse TestSetup to setup metadata and data in tracker web api tests
• maybe use TE service inside of the deduplication service. I'll do that if there is time. Right now it's odd that the service accepts TEs that might not even exist. That logic is in the controller. ACL is definitely also not done with the same level of detail as in the exporter service 😓

[muilpp]

it's definitely easier to understand the potential duplicate tests if we use this json, but didn't we say we want to have one json for metadata and one for data only?

[teleivo]

I am not sure that every tests requirements should affect all other tests 😅 All the exporter tests we have of which there are many do not need these TEs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud