fix: optimize QR code decode method in flaky 2FA test #20033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morten Svanaes <[email protected]>
vietnguyen
approved these changes
Feb 21, 2025
...dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/TwoFactorControllerTest.java
Show resolved
Hide resolved
jbee
approved these changes
Feb 24, 2025
Signed-off-by: Morten Svanaes <[email protected]>
netroms
changed the title
|
david-mackessy
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Flaky 2FA test TwoFactorControllerTest.testEnrollTOTP2FA , gives no stacktrace when it fails.
This is the only output we get when it fails:
And
com.google.zxing.ChecksumExceptionCause:
Seems to be the QR decode method can fail sometimes, due to lack of precision in the decoder.
There is a choice between performance/speed and accuracy in the decoder, and the default settings prefer speed.
Fix:
Tell the decoder to prefer accuracy.