-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not ignore measure criteria in aggregated analytics query [DHIS2-18788] #19986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9ee561
to
afaaeb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also add an e2e, we can chat later on
...tics/src/main/java/org/hisp/dhis/analytics/event/data/AbstractJdbcEventAnalyticsManager.java
Outdated
Show resolved
Hide resolved
1d8667f
to
1d2ca53
Compare
maikelarabori
approved these changes
Feb 20, 2025
|
vietnguyen
approved these changes
Feb 23, 2025
This was referenced Feb 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug with aggregated analytics query containing the
measureCriteria
parameter. The parameter is ignored and the filtering condition is not applied to the final SQL query.Problem
Given this query params:
The resulting SQL aggregated query does not contain the measuring criteria
Fix
measureFilter
data fromDataQueryParams
toEventQueryParams
having
clause to the query whenevermeasureFilter
is present inEventQueryParams
.3
e2e test cases to verify various scenarioFixed SQL aggregated query