-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update comments for dhis.conf keys #19042
Conversation
Looks good. There is a conflict @dayures . |
thanks @larshelge Can I help somehow to resolve the conflict? |
...upport/dhis-support-external/src/main/java/org/hisp/dhis/external/conf/ConfigurationKey.java
Outdated
Show resolved
Hide resolved
…sp/dhis/external/conf/ConfigurationKey.java
Hey @dayures , I resolved some conflicts and the PR is mostly ready to merge. The main thing remaining is formatting. Since this is a forked branch, the easiest solution is if you can run the formatting tool on your branch. You can do this by running "mvn spotless:apply", which will automatically format your changes. There is also an issue with SonarQube, where external forks are rejected (Since they are not part of the organisation). Due to the nature of this PR, I can force merge the PR, as long as all the other checks are passing (Like formatting). Let me know if you have any questions. |
Head branch was pushed to by a user without write access
Hi @stian-sandvold I did the changes (run the mvn spotless:apply) in my forked branch, and it looks like it passess the format tests. I hope it helps. |
Perfect, thank you @dayures , I merged the PR :) |
No description provided.