chore: [ANDROSDK-1983] Move DataValue to network layer #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarciabnz
reviewed
Jan 17, 2025
| val attributeOptionCombo: String, | ||
| val value: String?, | ||
| val storedBy: String?, | ||
| val created: String, |
There was a problem hiding this comment.
created and lastUpdated are not nullable, is it right?
| @Serializable | ||
| internal data class DataValueImportSummaryDTO( | ||
| val importCount: ImportCountDTO, | ||
| @SerialName("status") val importStatus: String, |
There was a problem hiding this comment.
Couldn't we just adapt the property name to avoid the definition of a different @SerialName ?
| import org.hisp.dhis.android.network.common.dto.WebResponseDTO | ||
|
|
||
| @Serializable | ||
| internal data class DataValueImportSummaryWebResponseDTO( |
There was a problem hiding this comment.
This is an example of a class that was originally created for the API and whose properties map 1to1 to the domain class. I think it is required if we want to keep them separated, but I feel it like a kind of duplication
| @@ -78,6 +79,10 @@ class D2 internal constructor(internal val d2DIComponent: D2DIComponent) { | |||
| return d2DIComponent.httpServiceClient | |||
| } | |||
|
|
|||
| fun httpServiceClientKotlinx(): HttpServiceClientKotlinx { | |||
There was a problem hiding this comment.
Couldn't it be internal at least? It should avoid all the modifications in HttpServiceClientKotlinx done in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task: ANDROSDK-1983