Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.9.1 #3477

Merged
merged 61 commits into from
Jan 29, 2024
Merged

Release 2.9.1 #3477

merged 61 commits into from
Jan 29, 2024

Conversation

xavimolloy
Copy link
Contributor

Description

Please include a summary of the change and include the related jira issue if it exists.

[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

ferdyrod and others added 30 commits October 26, 2023 15:19
* [ANDROAPP-5766] update gradle to 8.1.3

* [ANDROAPP-5766] update kotlin compiler to 1.5.4 and kotlin language to 1.9.20
…3418)

* update: [ANDROAPP-5743] valuetypes formatted correctly

* add: [ANDROAPP-5743] test added
* fix: [ANDROAPP-5700] save enrollment orgUnit

* verify setOrgUnit on test
)

* show new compose qr code bottomsheet

* fix lint error: remove unused imports

---------

Co-authored-by: Siddharth Agarwal <[email protected]>
…omplete (#3416)

* [ANDROAPP-5740] manage incomplete fields validation for new InputDateTime fields

* [ANDROAPP-5740] Manage incomplete date values in events and add tests for display name provider

* [ANDROAPP-5740] fix test

* [ANDROAPP-5740] sonar code smell fix
…dard interval days (#3422)

* [ANDROAPP-5630] managa Standard schedule interval in new event

* [ANDROAPP-5630] Take schedule interval days into account

* [ANDROAPP-5630] add instrumentation modular test for EventInitial
…dated (#3435)

* program rules now also apply when enrollment's data is changed

* program rules now also apply when enrollment's data is changed

---------

Co-authored-by: Ferdy Rodriguez <[email protected]>
* update: [ANDROAPP-5698] only add the last point once

* update: [ANDROAPP-5698] test fixed

* update: [ANDROAPP-5698] whenever someone edits the polygon, it's updated automatically

* update: [ANDROAPP-5698] code formatted

* update: [ANDROAPP-5698] remove duplicates using distinct, remove the last point

* update: [ANDROAPP-5698] test fixed
* update kotlin 1.9.21 and gradle 8.2.0

* update kotlincompiler 1.5.6

* Modify override method
…istent format (#3429)

* Add function to get plural with format arguments in `ResourceManager`

* Add extension function to create overdue UI text from date

* Use `toOverdueUiText` extension for setting overdue text in TEI card

* Extract private function string for getting overdue days string
* Adapt to changes in androsdk-1682

* Adapt unit tests
…ed (#3433)

* Replace `LazyColumn` with `Column` in `TeiDetailDashboard`

`LazyColumn` sets infinite height, if we have to place it inside another scroll view Compose will throw and runtime error saying that. We need to either set a fixed height to the `LazyColumn` or replace it with `Column` which wraps the content. Second one seemed like a good idea, so that it can react to content changes and recalculate the height.

* Wrap `cardLayout` and `tei_recycler` in nested scroll view

We have to 2 options to make the entire content scroll in this screen.

1. We migrate the events items to use Compose as well and move them into `TeiDetailDashboard`. Which is ideal, but requires significant migration of UI and associated code with it. Since that's out of scope didn't go with that.

2. Since in earlier commit I have change the `LazyColumn` to `Column`, we can now place the card and the events list inside a nested scroll view to make the entire content scroll.

The 2nd option seems like a sensible change for now, until we migrate events list and eventually this entire screen.

* Add new tei dashboard card support for landscape view

* Disable over scroll mode for nested scroll view and recycler view

* Show `card_front` in TEI dashboard landscape view only if program is available
mmmateos and others added 27 commits December 22, 2023 15:33
* fix: [ANDROAPP-5788] make field full visible on focus

* ktlint
… 3 transaction types (#3444)

* [ANDROAPP-5726] manage transaction type label through configured data element

* [ANDROAPP-5726] Add tests for new code

* feat: [ANDROAPP-5726] refactor code

* feat: [ANDROAPP-5726] adapt tests to new ui logic
* feat: [ANDROAPP-5824] update sdk to version 1.9.1-20231228.075857-13

* feat: [ANDROAPP-5824] add core library desugaring

* fix: [ANDROAPP-5824] add core library desugaring to maps module
#3453)

* fix: [ANDROAPP-5825] Incorrect calendar time instantiation, fix month parsing

* fix: [ANDROAPP-5825] manage onDateSet month correctly
* modify vName

* update python version

* update python script

* update python script

* run script with params

* format toml file

* update script

* commit changes in base branch

* setup git config

* update development and release version names
…3458)

* fix: [ANDROAPP-5803] ignore deleted events on schedule creation

* lint

* unit test
)

* fix: [ANDROAPP-5769] re-adapt data set groups request to coroutines, modify double call to data set detail fragment

* fix: [ANDROAPP-5769] fix double call to data set detail fragment

* fix: [ANDROAPP-5769] adapt DataSetListViewModelTest to new coroutine flow

* fix: [ANDROAPP-5769] remove unnecessary import

* fix: [ANDROAPP-5769] fix code smell
* fix: [ANDROAPP-5821] add new no options available logic

* feat: [ANDROAPP-5821] sonar code smell fixes refactor and clean-up code

* feat: [ANDROAPP-5821] refactor code for sonar fix and remove options available for create new event button visibility

* fix: [ANDROAPP-5821] add test for empty category selector
* [ANDROIDAP-5770] Update compose library to 1.5.4

* [ANDROAPP-5770] update tests to perform search
Copy link

sonarqubecloud bot commented Jan 29, 2024

@andresmr andresmr merged commit 94f13fb into main Jan 29, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants