fix: [ANDROAPP-5976] crash after discard or delete event (#3533)

dhis2 · Mar 13, 2024 · 09192f4 · 09192f4
1 parent 38f34ad
commit 09192f4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/...n/java/org/dhis2/usescases/eventsWithoutRegistration/eventCapture/EventCaptureActivity.kt b/...n/java/org/dhis2/usescases/eventsWithoutRegistration/eventCapture/EventCaptureActivity.kt
@@ -13,7 +13,6 @@ import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.viewpager2.widget.ViewPager2.OnPageChangeCallback
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
-import com.google.android.material.snackbar.BaseTransientBottomBar
 import com.google.android.material.snackbar.Snackbar
 import org.dhis2.R
 import org.dhis2.bindings.app
@@ -303,16 +302,12 @@ class EventCaptureActivity :
     }
 
     override fun showSnackBar(messageId: Int, programStage: String) {
-        val mySnackbar =
-            Snackbar.make(
-                binding.root,
-                resourceManager.formatWithEventLabel(
-                    messageId,
-                    programStage,
-                ),
-                BaseTransientBottomBar.LENGTH_SHORT,
-            )
-        mySnackbar.show()
+        showToast(
+            resourceManager.formatWithEventLabel(
+                messageId,
+                programStage,
+            ),
+        )
     }
 
     override fun restartDataEntry() {

diff --git a/...a/org/dhis2/usescases/eventsWithoutRegistration/eventCapture/EventCapturePresenterImpl.kt b/...a/org/dhis2/usescases/eventsWithoutRegistration/eventCapture/EventCapturePresenterImpl.kt
@@ -180,13 +180,14 @@ class EventCapturePresenterImpl(
     }
 
     override fun deleteEvent() {
+        val programStage = programStage()
         compositeDisposable.add(
             eventCaptureRepository.deleteEvent()
                 .defaultSubscribe(
                     schedulerProvider,
                     { result ->
                         if (result) {
-                            view.showSnackBar(R.string.event_label_was_deleted, programStage())
+                            view.showSnackBar(R.string.event_label_was_deleted, programStage)
                         }
                     },
                     Timber::e,

diff --git a/...a/org/dhis2/usescases/eventsWithoutRegistration/eventCapture/EventCapturePresenterTest.kt b/...a/org/dhis2/usescases/eventsWithoutRegistration/eventCapture/EventCapturePresenterTest.kt
@@ -138,6 +138,7 @@ class EventCapturePresenterTest {
     @Test
     fun `Should close form if it could not delete an event`() {
         whenever(eventRepository.deleteEvent()) doReturn Observable.just(false)
+        whenever(eventRepository.programStage()) doReturn Observable.just("programStage")
 
         presenter.deleteEvent()
         verify(view).finishDataEntry()