chore: add e2e dev workflow #3230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3230.dashboard.netlify.dhis2.org |
|
| username: ${{ secrets.CYPRESS_DHIS2_USERNAME }} | ||
| password: ${{ secrets.CYPRESS_DHIS2_PASSWORD }} | ||
|
|
||
| e2e-record: |
There was a problem hiding this comment.
Should the job name instead be e2e-tests-dev or similar?
|
|
||
| jobs: | ||
| compute-dev-version: | ||
| if: contains(github.event.pull_request.labels.*.name, 'e2e-record') |
There was a problem hiding this comment.
Shouldn't we use a different label than e2e-record to determine whether to run this workflow (here and line 36)? Most of the time I imagine people just want to run the tests without recording since it isn't needed most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need to blindly merge this PR so we have the workflow on the main branch. We can then start new branch from master and add the
e2e devlabel to it. I believe we should then see the job running on each commit. And that means we can start tweaking things until they work.There is also the off chance that I will have got everything right the first time around, but that would be quite unexpected 😄