feat: support custom 3rd party plugins along with platform plugins #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silences warnings in the console.
This hopefully has a better solution.
It should be enough to just use isParentCached for knowing when to start recording and removing the cache in the plugins.
This is to avoid the error boundary to show up for uncaught errors (failed to fetch a visualization) which interferes with Cypress testing.
* chore(deps): bump the security group with 3 updates Updates `ejs` from 3.1.8 to 3.1.10 - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.8...v3.1.10) Updates `tmpl` from 1.0.4 to 1.0.5 - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) Updates `word-wrap` from 1.2.3 to 1.2.5 - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect dependency-group: security - dependency-name: tmpl dependency-type: indirect dependency-group: security - dependency-name: word-wrap dependency-type: indirect dependency-group: security ... Signed-off-by: dependabot[bot] <[email protected]> * chore: break up command chain --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <[email protected]>
So it can be used also for custom 3rd-party plugins.
So it can be reused for different item types, ie. both VisualizationItem and AppItem.
…HIS2-17947) The same solution is used in VisualizationItem
This together with the fixes in app-runtime should solve he refresh on resize issues.
This is needed as the new plugin system is used, because the messages used in the communication have changed.
These are now reused for AppItem items too.
Don't render Plugin before knowing width and height.
Platform's plugin components rely on width and height in order to disable automatic resize.
Remove the Cover component as it does not cover anything...
|
🚀 Deployed on https://pr-3184.dashboard.netlify.dhis2.org |
…/dashboard-app into feat/custom-plugins-rebased-latest
jenniferarnesen
commented
Jan 17, 2025
| itemId: PropTypes.string, | ||
| onDeleteItem: PropTypes.func, | ||
| EditItemActions.defaultProps = { | ||
| onDelete: () => Promise.resolve(), |
There was a problem hiding this comment.
Could this default have unintended consequences by running the "finally" code even though nothing was deleted?
|
This was referenced Jan 17, 2025
jenniferarnesen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
Requires these PRs:
Key features
Description
Dashboard app should have support for custom plugins built with the DHIS2 tooling.
This assumes the plugin uses the platform's components that provide the postRobot communication compatible with this version of dashboard app.
TODO
Known issues