Skip to content

Commit

Permalink
fix: tabIndex is a string not a number
Browse files Browse the repository at this point in the history
  • Loading branch information
jenniferarnesen committed Dec 10, 2024
1 parent f1fc4c8 commit 9f4906f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
16 changes: 8 additions & 8 deletions i18n/en.pot
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2024-11-21T14:44:35.575Z\n"
"PO-Revision-Date: 2024-11-21T14:44:35.577Z\n"
"POT-Creation-Date: 2024-12-10T13:23:21.815Z\n"
"PO-Revision-Date: 2024-12-10T13:23:21.817Z\n"

msgid "Untitled dashboard"
msgstr "Untitled dashboard"
Expand Down Expand Up @@ -155,6 +155,12 @@ msgstr "Open this item in {{appName}}"
msgid "Not available offline"
msgstr "Not available offline"

msgid "Resources"
msgstr "Resources"

msgid "Reports"
msgstr "Reports"

msgid "Visualizations"
msgstr "Visualizations"

Expand All @@ -179,12 +185,6 @@ msgstr "Line lists"
msgid "Apps"
msgstr "Apps"

msgid "Reports"
msgstr "Reports"

msgid "Resources"
msgstr "Resources"

msgid "Users"
msgstr "Users"

Expand Down
2 changes: 1 addition & 1 deletion src/components/Item/VisualizationItem/Item.js
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class Item extends Component {
activeFooter={showFooter}
fullscreenSupported={this.isFullscreenSupported()}
loadItemFailed={this.state.loadItemFailed}
tabIndex={isSlideshowView ? -1 : 0}
tabIndex={isSlideshowView ? '-1' : '0'}
/>
) : null

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ ItemContextMenu.propTypes = {
fullscreenSupported: PropTypes.bool,
item: PropTypes.object,
loadItemFailed: PropTypes.bool,
tabIndex: PropTypes.number,
tabIndex: PropTypes.string,
visualization: PropTypes.object,
onSelectActiveType: PropTypes.func,
onToggleFooter: PropTypes.func,
Expand Down

0 comments on commit 9f4906f

Please sign in to comment.