Merge pull request #1796 from paneidos/raise-500-on-python-error

fix: return 500 Internal Server Error on python error

src/events/http/HttpServer.js

@@ -645,7 +645,7 @@ export default class HttpServer {
       /* RESPONSE SELECTION (among endpoint's possible responses) */
 
       // Failure handling
-      let errorStatusCode = "502"
+      let errorStatusCode = "500"
 
       if (err) {
         const errorMessage = (err.message || err).toString()
@@ -655,14 +655,17 @@ export default class HttpServer {
         if (found && found.length > 1) {
           ;[, errorStatusCode] = found
         } else {
-          errorStatusCode = "502"
+          errorStatusCode = "500"
         }
 
         // Mocks Lambda errors
         result = {
-          errorMessage,
-          errorType: err.constructor.name,
-          stackTrace: this.#getArrayStackTrace(err.stack),
+          body: JSON.stringify({
+            message: errorMessage,
+            stackTrace: this.#getArrayStackTrace(err.stack),
+            type: err.constructor.name,
+          }),
+          statusCode: errorStatusCode,
         }
 
         log.error(errorMessage)

src/lambda/handler-runner/python-runner/PythonRunner.js

@@ -104,9 +104,9 @@ export default class PythonRunner {
       })
 
       const onErr = (data) => {
-        // TODO
-
         log.notice(data.toString())
+
+        rej(new Error("Internal Server Error"))
       }
 
       const onLine = (line) => {

tests/runtimes/python/python3/handler.py

@@ -9,3 +9,6 @@ def hello(event, context):
         "body": json.dumps(body),
         "statusCode": 200,
     }
+
+def error(event, context):
+    raise Exception("This is an error")

tests/runtimes/python/python3/python3.test.js

@@ -37,4 +37,13 @@ describe("Python 3 tests", function desc() {
       assert.deepEqual(json, expected)
     })
   })
+
+  it("should return a 500 on error", async () => {
+    const url = new URL("/dev/error", BASE_URL)
+    const response = await fetch(url)
+    const json = await response.json()
+
+    assert.equal(response.status, 500)
+    assert.equal(json.message, "Internal Server Error")
+  })
 })

tests/runtimes/python/python3/serverless.yml

@@ -23,3 +23,9 @@ functions:
           method: get
           path: hello
     handler: handler.hello
+  error:
+    events:
+      - http:
+          method: get
+          path: error
+    handler: handler.error