fix: treat application/octet-stream as a binary encoding (#1587)

* fix: treat application/octet-stream as a binary encoding

* chore: prettier fix

---------

Co-authored-by: Dorian <[email protected]>
Co-authored-by: MazurDorian <[email protected]>

src/utils/index.js

@@ -21,13 +21,20 @@ export { generateAlbHapiPath } from "./generateHapiPath.js"
 const { isArray } = Array
 const { keys } = Object
 
+const possibleBinaryContentTypes = [
+  "application/octet-stream",
+  "multipart/form-data",
+]
+
 // Detect the toString encoding from the request headers content-type
 // enhance if further content types need to be non utf8 encoded.
 export function detectEncoding(request) {
   const contentType = request.headers["content-type"]
 
   return typeof contentType === "string" &&
-    contentType.includes("multipart/form-data")
+    possibleBinaryContentTypes.some((possibleBinaryContentType) =>
+      contentType.includes(possibleBinaryContentType),
+    )
     ? "binary"
     : "utf8"
 }

tests/old-unit/utils.test.js

@@ -49,6 +49,17 @@ describe("utils", () => {
       })
     })
 
+    describe("with application/octet-stream content-type", () => {
+      it("should return binary", () => {
+        const request = {
+          headers: {
+            "content-type": "application/octet-stream",
+          },
+        }
+        assert.strictEqual(detectEncoding(request), "binary")
+      })
+    })
+
     describe("with multipart/form-data content-type", () => {
       it("should return binary", () => {
         const request = {