Skip to content

Son/techn 368 get config from appconfiguration instead #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Son/techn 368 get config from appconfiguration instead #98

wants to merge 2 commits into from

Conversation

@nsonanh
Copy link
Contributor

@nsonanh nsonanh commented Dec 15, 2022 •
edited
Loading

This is for @todo task:

  • // @todo should use AppConfiguration on line 118 of LogService.ts

Commits:

  • [@dhealthdapps/backend] refactor: implement getConfig() in AppConfiguration & update classes to use it instead of direct loader calls
  • [@dhealthdapps/backend] fix: linter issues

@nsonanh nsonanh self-assigned this Dec 15, 2022
@linear
Copy link

linear bot commented Dec 15, 2022

TECHN-368

@nsonanh nsonanh requested a review from evias December 15, 2022 16:18
@nsonanh nsonanh changed the title [@dhealthdapps/backend] refactor: implement getConfig() in AppConfiguration & update classes to use it instead of direct loader calls Son/techn 368 get config from appconfiguration instead Dec 15, 2022
@evias evias force-pushed the son/techn-367-define-class-abstractappmodule-and-use branch from 8907d67 to 6b31a9e Compare December 22, 2022 14:38
@nsonanh nsonanh force-pushed the son/techn-368-get-config-from-appconfiguration-instead branch from 8bdcb30 to 6111995 Compare January 13, 2023 06:49
@nsonanh nsonanh changed the base branch from son/techn-367-define-class-abstractappmodule-and-use to next January 13, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vega-hit vega-hit vega-hit approved these changes

@evias evias Awaiting requested review from evias

Assignees

@nsonanh nsonanh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsonanh @vega-hit