Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving speed setting below interface type setting #44

Closed
wants to merge 1 commit into from

Conversation

dgsudharsan
Copy link
Owner

@dgsudharsan dgsudharsan commented Sep 3, 2024

What I did
Moved speed setting below interface type setting in the processing order. Sometimes the interface type settings are required to set proper speed and to avoid ambiguity (e.g. 100G can be set on 2 lanes in PAM4 case or 4 lanes in case of NRZ case which is decided by interface type).

When user configures speed and interface type commands next to next, it may be combined as a single update due to optimization in orchagent and with the current order it may result in speed getting processed before interface type.

User commands

2024 Aug 29 00:06:16.683596 mtvr-hippo-01 NOTICE sudo:    admin : TTY=pts/1 ; PWD=/home/admin ; USER=root ; COMMAND=/usr/local/bin/config interface type Ethernet336 none
2024 Aug 29 00:06:18.295811 mtvr-hippo-01 NOTICE sudo:    admin : TTY=pts/1 ; PWD=/home/admin ; USER=root ; COMMAND=/usr/local/bin/config interface speed Ethernet336 25000

SWSS record

2024-08-28.21:06:19.117532|PORT_TABLE:Ethernet336|SET|alias:etp43|index:43|lanes:336,337,338,339,340,341,342,343|speed:25000|autoneg:off|interface_type:none|adv_speeds:400000|adv_interface_types:CR8|fec:rs|mtu:9100|admin_status:down

Why I did it
Moved processing of speed setting after interface type in order to avoid any error in programming SAI.

How I verified it
Existing tests should verify the current functionality. Ordering cannot be tested with the current vs test infrastructure.

Details if related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant