Moving speed setting below interface type setting #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Moved speed setting below interface type setting in the processing order. Sometimes the interface type settings are required to set proper speed and to avoid ambiguity (e.g. 100G can be set on 2 lanes in PAM4 case or 4 lanes in case of NRZ case which is decided by interface type).
When user configures speed and interface type commands next to next, it may be combined as a single update due to optimization in orchagent and with the current order it may result in speed getting processed before interface type.
User commands
SWSS record
Why I did it
Moved processing of speed setting after interface type in order to avoid any error in programming SAI.
How I verified it
Existing tests should verify the current functionality. Ordering cannot be tested with the current vs test infrastructure.
Details if related