-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 #94
Merged
Python 3.12 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technically the value should be in an annotation scope, I can't see any difference for our use. They are supposed to behave as if executing the parent's namespace.
This module does redefine some things, tell mypy that's not a problem
1 task
Fix to pass with non-deterministic dict order
…ntext They create a new binding in the class namespace
These will become class attributes. This fixes situations where renaming was allowed due to the actual namebinding being placed in a nonlocal scope by a name in load context in the class scope.
The previous checks were not enough, as name references we know are a builtin could get redefined in class scope.
Fix ClassDef Name binding
It's not practical to rename type parameters safely until we can properly model annotation namespaces.
preserve_locals/globals should be a list. Cast it to a list if it looks like it has mistaken been passed as a string.
Add type parameter renaming support
Thanks for all the effort, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Python 3.12 support